Sam/oriole17 flake check #1399
Merged
Sam/oriole17 flake check #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* separate pg17 and oriole test diffs * ignore minor diffs in float value * update pgmq after-create script for pg 17 * all tests fixed except interface * sync tests * move postgis_tiger_geocoder to ext_interface * align pg 17 extension interface tests
…_jsonschema for orioledb
|
This pr deprecates pg 16 for now as well |
pcnc
approved these changes
Jan 14, 2025
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* chore: WIP check harness * chore: consolidate start-server/start-client * chore: consolidate start-server, start-client and check harness * chore: rm dup cleanup * chore: do not run pg with overmin, just pg_ctl in daemon mode * chore: deprecate x86_64-darwin and run check on oriole17 * wip toward fixing for all systems * chore: refactoring to create reusable makePostgresDevSetup * chore: tweaks to run-server.sh.in top account for oriole on macos * chore: remove x86_64-darwin support * Isolate failing tests on pg17 and OrioleDB (supabase#1402) * separate pg17 and oriole test diffs * ignore minor diffs in float value * update pgmq after-create script for pg 17 * all tests fixed except interface * sync tests * move postgis_tiger_geocoder to ext_interface * align pg 17 extension interface tests * chore: getting pg tap tests and pg_regress tests to run for pg_15 and oriole 17 * chore: do not build or cache pg 16 for now * chore: wip running pgtap and pgreress tests + rm pg 16 for now * chore: fix tests to account for architecture differences3 * chore: deactivate tests and builds for pg 16 * chore: will pull pg 16 from vars in future pr * chore: update to unit test in ansible build include pg_grapqhl and pg_jsonschema for orioledb * chore: also include pgrouting and postgis in orioledb test * chore: tmp deactivate postgis on this test * chore: rm from list of exts in test too * chore: was missing KEY_FILE var in script * chore: deprecate 16 from versions --------- Co-authored-by: Oliver Rice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR consolidates
start-clientflake app intostart-server, and then usesstart-serverin themakeCheckHarnessnix flake check, and in that flake check, brings in the rest of the migrations and config to match our AMI set up as closely as possible. start-client now just wrapspsqlfor the version of postgres we're running.start-serverinherits the--migration-filecapability, and has an optional--skip-migrationsIn addition, this PR refactors start-server to start/stop postgres with https://github.com/DarthSim/overmind so that managing the running service in foreground, background, etc is simpler. The script handles all interaction with overmind, so the
nix runcommands are unchanged other than the new flags.This PR will remain in DRAFT mode until the flake checks pass.